Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fee abs module #780

Merged
merged 63 commits into from
Sep 24, 2024
Merged

feat: add fee abs module #780

merged 63 commits into from
Sep 24, 2024

Conversation

atheeshp
Copy link
Collaborator

@atheeshp atheeshp commented Aug 27, 2024 •
edited
Loading

closes: #775

@atheeshp atheeshp changed the base branch from main to develop August 28, 2024 05:27
Eengineer1
Eengineer1 requested changes Sep 10, 2024
View reviewed changes
app/ante.go Outdated Show resolved Hide resolved
@atheeshp atheeshp changed the base branch from develop to vishal/integrate-antehandler September 11, 2024 06:49
Eengineer1
Eengineer1 requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core work looks good.

Please, address + resolve the remarks, before eventually promoting the combined work.

app/app.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
post/tax.go Outdated Show resolved Hide resolved
ante/fee_test.go Outdated Show resolved Hide resolved
Base automatically changed from vishal/integrate-antehandler to develop September 20, 2024 13:58
@Eengineer1
Copy link
Contributor

@atheeshp or @vishal-kanna Could you please resolve conflicts preparing the PR for a final review?

Eengineer1
Eengineer1 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks well polished.

Approved.

@Eengineer1 Eengineer1 merged commit 0c060fc into develop Sep 24, 2024
17 checks passed
@Eengineer1 Eengineer1 deleted the ap/add-feeabs-mod branch September 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Eengineer1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature]: integrate x/feeabs module in app
3 participants
@atheeshp @Eengineer1 @vishal-kanna